Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b1290e5 authored by Wenliang Fan's avatar Wenliang Fan Committed by Greg Kroah-Hartman
Browse files

drivers/staging/bcm: Integer overflow 



The checking condition in 'validateFlash2xReadWrite()' is not
sufficient. A large number invalid would cause an integer overflow and
pass the condition, which could cause further integer overflows in
'Bcmchar.c:bcm_char_ioctl()'.

Signed-off-by: default avatarWenliang Fan <fanwlexca@gmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01b6442b

drivers/staging/bcm/nvm.c

+9 −0
Original line number Diff line number Diff line
@@ -3944,6 +3944,15 @@ int validateFlash2xReadWrite(struct bcm_mini_adapter *Adapter, struct bcm_flash2 


	BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, NVM_RW, DBG_LVL_ALL, "End offset :%x\n", uiSectEndOffset);



	/* psFlash2xReadWrite->offset and uiNumOfBytes are user controlled and can lead to integer overflows */

	if (psFlash2xReadWrite->offset > uiSectEndOffset) {

		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, "Invalid Request....");

		return false;

	}

	if (uiNumOfBytes > uiSectEndOffset) {

		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, "Invalid Request....");

		return false;

	}

	/* Checking the boundary condition */

	if ((uiSectStartOffset + psFlash2xReadWrite->offset + uiNumOfBytes) <= uiSectEndOffset)

		return TRUE;