Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ae7297b authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Greg Kroah-Hartman
Browse files

iio: Fix scan mask selection 



commit 20ea39ef9f2f911bd01c69519e7d69cfec79fde3 upstream.

The trialmask is expected to have all bits set to 0 after allocation.
Currently kmalloc_array() is used which does not zero the memory and so
random bits are set. This results in random channels being enabled when
they shouldn't. Replace kmalloc_array() with kcalloc() which has the same
interface but zeros the memory.

Note the fix is actually required earlier than the below fixes tag, but
will require a manual backport due to move from kmalloc to kmalloc_array.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarAlexandru Ardelean <alexandru.ardelean@analog.com>
Fixes commit 057ac1ac ("iio: Use kmalloc_array() in iio_scan_mask_set()").
Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8ba5d597

drivers/iio/industrialio-buffer.c

+2 −3
Original line number Diff line number Diff line
@@ -320,9 +320,8 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev, 
	const unsigned long *mask;

	unsigned long *trialmask;



	trialmask = kmalloc_array(BITS_TO_LONGS(indio_dev->masklength),

				  sizeof(*trialmask),

				  GFP_KERNEL);

	trialmask = kcalloc(BITS_TO_LONGS(indio_dev->masklength),

			    sizeof(*trialmask), GFP_KERNEL);

	if (trialmask == NULL)

		return -ENOMEM;

	if (!indio_dev->masklength) {