Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a4adb05 authored by Ravikant B Sharma's avatar Ravikant B Sharma Committed by Sinclair Yeh
Browse files

drm/vmwgfx: Fix NULL pointer comparison 



Replace direct comparisons to NULL i.e.
'x == NULL' with '!x'. As per coding standard.

Signed-off-by: default avatarRavikant B Sharma <ravikant.s2@samsung.com>
Reviewed-by: default avatarSinclair Yeh <syeh@vmware.com>
Signed-off-by: default avatarSinclair Yeh <syeh@vmware.com>
parent 9ff1beb1

drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c

+2 −2
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man, 
	int ret;



	cres = kzalloc(sizeof(*cres), GFP_KERNEL);

	if (unlikely(cres == NULL))

	if (unlikely(!cres))

		return -ENOMEM;



	cres->hash.key = user_key | (res_type << 24);
@@ -291,7 +291,7 @@ vmw_cmdbuf_res_man_create(struct vmw_private *dev_priv) 
	int ret;



	man = kzalloc(sizeof(*man), GFP_KERNEL);

	if (man == NULL)

	if (!man)

		return ERR_PTR(-ENOMEM);



	man->dev_priv = dev_priv;

drivers/gpu/drm/vmwgfx/vmwgfx_context.c

+1 −1
Original line number Diff line number Diff line
@@ -776,7 +776,7 @@ static int vmw_context_define(struct drm_device *dev, void *data, 
	}



	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);

	if (unlikely(ctx == NULL)) {

	if (unlikely(!ctx)) {

		ttm_mem_global_free(vmw_mem_glob(dev_priv),

				    vmw_user_context_size);

		ret = -ENOMEM;

drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c

+1 −1
Original line number Diff line number Diff line
@@ -583,7 +583,7 @@ struct vmw_resource *vmw_cotable_alloc(struct vmw_private *dev_priv, 
		return ERR_PTR(ret);



	vcotbl = kzalloc(sizeof(*vcotbl), GFP_KERNEL);

	if (unlikely(vcotbl == NULL)) {

	if (unlikely(!vcotbl)) {

		ret = -ENOMEM;

		goto out_no_alloc;

	}

drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

+3 −3
Original line number Diff line number Diff line
@@ -630,7 +630,7 @@ static int vmw_driver_load(struct drm_device *dev, unsigned long chipset) 
	char host_log[100] = {0};



	dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL);

	if (unlikely(dev_priv == NULL)) {

	if (unlikely(!dev_priv)) {

		DRM_ERROR("Failed allocating a device private struct.\n");

		return -ENOMEM;

	}
@@ -1035,7 +1035,7 @@ static int vmw_driver_open(struct drm_device *dev, struct drm_file *file_priv) 
	int ret = -ENOMEM;



	vmw_fp = kzalloc(sizeof(*vmw_fp), GFP_KERNEL);

	if (unlikely(vmw_fp == NULL))

	if (unlikely(!vmw_fp))

		return ret;



	vmw_fp->tfile = ttm_object_file_init(dev_priv->tdev, 10);
@@ -1196,7 +1196,7 @@ static int vmw_master_create(struct drm_device *dev, 
	struct vmw_master *vmaster;



	vmaster = kzalloc(sizeof(*vmaster), GFP_KERNEL);

	if (unlikely(vmaster == NULL))

	if (unlikely(!vmaster))

		return -ENOMEM;



	vmw_master_init(vmaster);

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

+2 −2
Original line number Diff line number Diff line
@@ -264,7 +264,7 @@ static int vmw_resource_val_add(struct vmw_sw_context *sw_context, 
	}



	node = kzalloc(sizeof(*node), GFP_KERNEL);

	if (unlikely(node == NULL)) {

	if (unlikely(!node)) {

		DRM_ERROR("Failed to allocate a resource validation "

			  "entry.\n");

		return -ENOMEM;
@@ -452,7 +452,7 @@ static int vmw_resource_relocation_add(struct list_head *list, 
	struct vmw_resource_relocation *rel;



	rel = kmalloc(sizeof(*rel), GFP_KERNEL);

	if (unlikely(rel == NULL)) {

	if (unlikely(!rel)) {

		DRM_ERROR("Failed to allocate a resource relocation.\n");

		return -ENOMEM;

	}