Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17dcfc9b authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman
Browse files

USB: EHCI: remove useless test 



This patch (as1605) removes a useless test from the EHCI debugfs
code.  There's no point checking whether p.qh is non-NULL; we already
know it is and in any case it gets dereferenced aerlier in the
function.

The useless test was identified by smatch.

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0cb72e18

drivers/usb/host/ehci-dbg.c

+2 −4
Original line number Diff line number Diff line
@@ -653,10 +653,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) 
						seen [seen_count++].qh = p.qh;

				} else

					temp = 0;

				if (p.qh) {

				tag = Q_NEXT_TYPE(ehci, hw->hw_next);

				p = p.qh->qh_next;

				}

				break;

			case Q_TYPE_FSTN:

				temp = scnprintf (next, size,