Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17c45c4d authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (max1111) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent ce847a33

drivers/hwmon/max1111.c

+2 −2
Original line number Diff line number Diff line
@@ -98,7 +98,7 @@ EXPORT_SYMBOL(max1111_read_channel); 
 * likely to be used by hwmon applications to distinguish between

 * different devices, explicitly add a name attribute here.

 */

static ssize_t show_name(struct device *dev,

static ssize_t name_show(struct device *dev,

			 struct device_attribute *attr, char *buf)

{

	return sprintf(buf, "%s\n", to_spi_device(dev)->modalias);
@@ -125,7 +125,7 @@ static ssize_t show_adc(struct device *dev, 
#define MAX1111_ADC_ATTR(_id)		\

	SENSOR_DEVICE_ATTR(in##_id##_input, S_IRUGO, show_adc, NULL, _id)



static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);

static DEVICE_ATTR_RO(name);

static MAX1111_ADC_ATTR(0);

static MAX1111_ADC_ATTR(1);

static MAX1111_ADC_ATTR(2);