Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 178554ae authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds
Browse files

Memory leak in tpm_ascii_bios_measurements_open() 



Coverity found a memory leak in tpm_ascii_bios_measurements_open().

If "read_log(log)" fails, then we may leak 'log' and
'log->bios_event_log'.

Signed-off-by: default avatarJesper Juhl <jesper.juhl@gmail.com>
Cc: Seiji Munetoh <munetoh@jp.ibm.com>
Cc: Stefan Berger <stefanb@us.ibm.com>
Cc: Reiner Sailer <sailer@watson.ibm.com>
Cc: Kylene Hall <kjhall@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 22982a56

drivers/char/tpm/tpm_bios.c

+8 −3
Original line number Diff line number Diff line
@@ -427,7 +427,7 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode, 
		return -ENOMEM;



	if ((err = read_log(log)))

		return err;

		goto out_free;



	/* now register seq file */

	err = seq_open(file, &tpm_ascii_b_measurments_seqops);
@@ -435,10 +435,15 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode, 
		seq = file->private_data;

		seq->private = log;

	} else {

		kfree(log->bios_event_log);

		kfree(log);

		goto out_free;

	}



out:

	return err;

out_free:

	kfree(log->bios_event_log);

	kfree(log);

	goto out;

}



const struct file_operations tpm_ascii_bios_measurements_ops = {