Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16ac345b authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Sebastian Reichel
Browse files

power: supply: add const to bin_attribute structures 



Add const to bin_attribute structures as they are only passed to the
functions sysfs_{remove/create}_bin_file or
device_{remove/create}_bin_file. The corresponding parameters
passed are of type const, so declare the structures to be const.

Done using Coccinelle:

@m disable optional_qualifier@
identifier s;
position p;
@@
static struct bin_attribute s@p={...};

@okay1@
position p;
identifier m.s;
@@
(
sysfs_create_bin_file(...,&s@p,...)
|
sysfs_remove_bin_file(...,&s@p,...)
)

@bad@
position p!={m.p,okay1.p};
identifier m.s;
@@
s@p

@change depends on !bad disable optional_qualifier@
identifier m.s;
@@
static
+const
struct bin_attribute s={...};

Same script was modified for device_{create/remove}_bin_file functions.

Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent 67bd22c0

drivers/power/supply/ds2780_battery.c

+2 −2
Original line number Diff line number Diff line
@@ -663,7 +663,7 @@ static ssize_t ds2780_write_param_eeprom_bin(struct file *filp, 
	return count;

}



static struct bin_attribute ds2780_param_eeprom_bin_attr = {

static const struct bin_attribute ds2780_param_eeprom_bin_attr = {

	.attr = {

		.name = "param_eeprom",

		.mode = S_IRUGO | S_IWUSR,
@@ -708,7 +708,7 @@ static ssize_t ds2780_write_user_eeprom_bin(struct file *filp, 
	return count;

}



static struct bin_attribute ds2780_user_eeprom_bin_attr = {

static const struct bin_attribute ds2780_user_eeprom_bin_attr = {

	.attr = {

		.name = "user_eeprom",

		.mode = S_IRUGO | S_IWUSR,

drivers/power/supply/ds2781_battery.c

+2 −2
Original line number Diff line number Diff line
@@ -665,7 +665,7 @@ static ssize_t ds2781_write_param_eeprom_bin(struct file *filp, 
	return count;

}



static struct bin_attribute ds2781_param_eeprom_bin_attr = {

static const struct bin_attribute ds2781_param_eeprom_bin_attr = {

	.attr = {

		.name = "param_eeprom",

		.mode = S_IRUGO | S_IWUSR,
@@ -711,7 +711,7 @@ static ssize_t ds2781_write_user_eeprom_bin(struct file *filp, 
	return count;

}



static struct bin_attribute ds2781_user_eeprom_bin_attr = {

static const struct bin_attribute ds2781_user_eeprom_bin_attr = {

	.attr = {

		.name = "user_eeprom",

		.mode = S_IRUGO | S_IWUSR,

drivers/power/supply/olpc_battery.c

+1 −1
Original line number Diff line number Diff line
@@ -535,7 +535,7 @@ static ssize_t olpc_bat_eeprom_read(struct file *filp, struct kobject *kobj, 
	return count;

}



static struct bin_attribute olpc_bat_eeprom = {

static const struct bin_attribute olpc_bat_eeprom = {

	.attr = {

		.name = "eeprom",

		.mode = S_IRUGO,