Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 168586e9 authored by Vinayak Menon's avatar Vinayak Menon
Browse files

Revert "mm/memblock: fix a race between search and remove" 



This reverts commit eb292c2a.

The reverted patch is part of the unused no-map-fixup feature
which is being removed.

Change-Id: I991db27193be58541348535f40fe87c7a0242148
Signed-off-by: default avatarVinayak Menon <vinmenon@codeaurora.org>
parent f6d70f4c

drivers/base/dma-removed.c

+0 −2
Original line number Diff line number Diff line
@@ -186,10 +186,8 @@ static void removed_region_fixup(struct removed_region *dma_mem, int index) 
		return;



	/* carve-out */

	memblock_region_resize_late_begin();

	memblock_free(dma_mem->base, dma_mem->nr_pages * PAGE_SIZE);

	memblock_remove(dma_mem->base, index * PAGE_SIZE);

	memblock_region_resize_late_end();



	/* clear page-mappings */

	base_pfn = dma_mem->base >> PAGE_SHIFT;

include/linux/memblock.h

+0 −2
Original line number Diff line number Diff line
@@ -90,8 +90,6 @@ int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); 
int memblock_mark_nomap(phys_addr_t base, phys_addr_t size);

int memblock_clear_nomap(phys_addr_t base, phys_addr_t size);

ulong choose_memblock_flags(void);

void memblock_region_resize_late_begin(void);

void memblock_region_resize_late_end(void);



/* Low level functions */

int memblock_add_range(struct memblock_type *type,

mm/memblock.c

+2 −45
Original line number Diff line number Diff line
@@ -19,8 +19,6 @@ 
#include <linux/debugfs.h>

#include <linux/seq_file.h>

#include <linux/memblock.h>

#include <linux/preempt.h>

#include <linux/seqlock.h>



#include <asm/sections.h>

#include <linux/io.h>
@@ -33,7 +31,6 @@ static struct memblock_region memblock_reserved_init_regions[INIT_MEMBLOCK_REGIO 
static struct memblock_region memblock_physmem_init_regions[INIT_PHYSMEM_REGIONS] __initdata_memblock;

#endif



static seqcount_t memblock_seq;

struct memblock memblock __initdata_memblock = {

	.memory.regions		= memblock_memory_init_regions,

	.memory.cnt		= 1,	/* empty dummy entry */
@@ -1555,7 +1552,7 @@ void __init memblock_mem_limit_remove_map(phys_addr_t limit) 
	memblock_cap_memory_range(0, max_addr);

}



static int __init_memblock __memblock_search(struct memblock_type *type,

static int __init_memblock memblock_search(struct memblock_type *type,

					phys_addr_t addr)

{

	unsigned int left = 0, right = type->cnt;
@@ -1574,20 +1571,6 @@ static int __init_memblock __memblock_search(struct memblock_type *type, 
	return -1;

}



static int __init_memblock memblock_search(struct memblock_type *type,

					   phys_addr_t addr)

{

	int ret;

	unsigned long seq;



	do {

		seq = raw_read_seqcount_begin(&memblock_seq);

		ret = __memblock_search(type, addr);

	} while (unlikely(read_seqcount_retry(&memblock_seq, seq)));



	return ret;

}



bool __init memblock_is_reserved(phys_addr_t addr)

{

	return memblock_search(&memblock.reserved, addr) != -1;
@@ -1772,32 +1755,6 @@ void __init memblock_allow_resize(void) 
	memblock_can_resize = 1;

}



static void __init_memblock memblock_resize_late(int begin)

{

	static int memblock_can_resize_old;



	if (begin) {

		preempt_disable();

		memblock_can_resize_old = memblock_can_resize;

		memblock_can_resize = 0;

		raw_write_seqcount_begin(&memblock_seq);

	} else {

		raw_write_seqcount_end(&memblock_seq);

		memblock_can_resize = memblock_can_resize_old;

		preempt_enable();

	}

}



void __init_memblock memblock_region_resize_late_begin(void)

{

	memblock_resize_late(1);

}



void __init_memblock memblock_region_resize_late_end(void)

{

	memblock_resize_late(0);

}



static int __init early_memblock(char *p)

{

	if (p && strstr(p, "debug"))