Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1664d7fd authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck
Browse files

hwmon: (via-cputemp) use permission-specific DEVICE_ATTR variants 



Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 2d1c4cf1

drivers/hwmon/via-cputemp.c

+3 −3
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static ssize_t show_temp(struct device *dev, 
	return sprintf(buf, "%lu\n", ((unsigned long)eax & 0xffffff) * 1000);

}



static ssize_t show_cpu_vid(struct device *dev,

static ssize_t cpu0_vid_show(struct device *dev,

			     struct device_attribute *devattr, char *buf)

{

	struct via_cputemp_data *data = dev_get_drvdata(dev);
@@ -119,7 +119,7 @@ static const struct attribute_group via_cputemp_group = { 
};



/* Optional attributes */

static DEVICE_ATTR(cpu0_vid, S_IRUGO, show_cpu_vid, NULL);

static DEVICE_ATTR_RO(cpu0_vid);



static int via_cputemp_probe(struct platform_device *pdev)

{