Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15d8061b authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by Bartlomiej Zolnierkiewicz
Browse files

ide: Fix cs5535 driver accessing beyond array boundary 



The cs5535 uses an incorrect construct to access the other drive of a pair,
causing it to access beyond an array boundary on the secondary interface.

This fixes it by using the new ide_get_paired_drive() helper instead.

Bart: patch description fixes

Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
parent a87a87cc

drivers/ide/pci/cs5535.c

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t *drive, const u8 speed) 


	/* Set the PIO timings */

	if ((speed & XFER_MODE) == XFER_PIO) {

		ide_drive_t *pair = &drive->hwif->drives[drive->dn ^ 1];

		ide_drive_t *pair = ide_get_paired_drive(drive);

		u8 cmd, pioa;



		cmd = pioa = speed - XFER_PIO_0;