Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 156f92f2 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach
Browse files

iwlwifi: block the queues when we send ADD_STA for uAPSD 



We send an ADD_STA to instruct the firmware to release
frames despite the peer being in PS.
Since the ADD_STA command and the Tx frame that comes
immediately afterwards can be reordered by the DMA engine,
we need to block the Tx queues until the firmware replies
with the ADD_STA response.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent dcbb4746

drivers/net/wireless/intel/iwlwifi/mvm/ops.c

+13 −0
Original line number Diff line number Diff line
@@ -839,6 +839,18 @@ static void iwl_mvm_stop_sw_queue(struct iwl_op_mode *op_mode, int queue) 
	}

}



static void iwl_mvm_async_cb(struct iwl_op_mode *op_mode,

			     const struct iwl_device_cmd *cmd)

{

	struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode);



	/*

	 * For now, we only set the CMD_WANT_ASYNC_CALLBACK for ADD_STA

	 * commands that need to block the Tx queues.

	 */

	iwl_trans_block_txq_ptrs(mvm->trans, false);

}



static void iwl_mvm_wake_sw_queue(struct iwl_op_mode *op_mode, int queue)

{

	struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode);
@@ -1414,6 +1426,7 @@ int iwl_mvm_exit_d0i3(struct iwl_op_mode *op_mode) 


#define IWL_MVM_COMMON_OPS					\

	/* these could be differentiated */			\

	.async_cb = iwl_mvm_async_cb,				\

	.queue_full = iwl_mvm_stop_sw_queue,			\

	.queue_not_full = iwl_mvm_wake_sw_queue,		\

	.hw_rf_kill = iwl_mvm_set_hw_rfkill_state,		\

drivers/net/wireless/intel/iwlwifi/mvm/sta.c

+6 −1
Original line number Diff line number Diff line
@@ -1708,7 +1708,12 @@ void iwl_mvm_sta_modify_sleep_tx_count(struct iwl_mvm *mvm, 
		cmd.sleep_state_flags |= cpu_to_le16(STA_SLEEP_STATE_UAPSD);

	}



	ret = iwl_mvm_send_cmd_pdu(mvm, ADD_STA, CMD_ASYNC, sizeof(cmd), &cmd);

	/* block the Tx queues until the FW updated the sleep Tx count */

	iwl_trans_block_txq_ptrs(mvm->trans, true);



	ret = iwl_mvm_send_cmd_pdu(mvm, ADD_STA,

				   CMD_ASYNC | CMD_WANT_ASYNC_CALLBACK,

				   sizeof(cmd), &cmd);

	if (ret)

		IWL_ERR(mvm, "Failed to send ADD_STA command (%d)\n", ret);

}