Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 145fe1e1 authored by Sachin Kamat's avatar Sachin Kamat Committed by Mark Brown
Browse files

regulator: fan53555: Do not hardcode return values 



Propagate the error values returned by the function instead.

Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 38dbfb59

drivers/regulator/fan53555.c

+4 −4
Original line number Diff line number Diff line
@@ -90,11 +90,11 @@ static int fan53555_set_suspend_voltage(struct regulator_dev *rdev, int uV) 
		return 0;

	ret = regulator_map_voltage_linear(rdev, uV, uV);

	if (ret < 0)

		return -EINVAL;

		return ret;

	ret = regmap_update_bits(di->regmap, di->sleep_reg,

					VSEL_NSEL_MASK, ret);

	if (ret < 0)

		return -EINVAL;

		return ret;

	/* Cache the sleep voltage setting.

	 * Might not be the real voltage which is rounded */

	di->sleep_vol_cache = uV;
@@ -260,14 +260,14 @@ static int fan53555_regulator_probe(struct i2c_client *client, 
	ret = regmap_read(di->regmap, FAN53555_ID1, &val);

	if (ret < 0) {

		dev_err(&client->dev, "Failed to get chip ID!\n");

		return -ENODEV;

		return ret;

	}

	di->chip_id = val & DIE_ID;

	/* Get chip revision */

	ret = regmap_read(di->regmap, FAN53555_ID2, &val);

	if (ret < 0) {

		dev_err(&client->dev, "Failed to get chip Rev!\n");

		return -ENODEV;

		return ret;

	}

	di->chip_rev = val & DIE_REV;

	dev_info(&client->dev, "FAN53555 Option[%d] Rev[%d] Detected!\n",