Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 142fb5b7 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

iwlwifi: add __printf argument checking 



Joe Perches suggested adding the __printf attribute
to the __iwl_dbg function to check arguments; add it
to all of the logging functions (err, warn, info, dbg
and crit.)

Reviewed-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent a35e2708

drivers/net/wireless/iwlwifi/iwl-debug.h

+6 −6
Original line number Diff line number Diff line
@@ -38,10 +38,10 @@ static inline bool iwl_have_debug_level(u32 level) 
}



void __iwl_err(struct device *dev, bool rfkill_prefix, bool only_trace,

		const char *fmt, ...);

void __iwl_warn(struct device *dev, const char *fmt, ...);

void __iwl_info(struct device *dev, const char *fmt, ...);

void __iwl_crit(struct device *dev, const char *fmt, ...);

		const char *fmt, ...) __printf(4, 5);

void __iwl_warn(struct device *dev, const char *fmt, ...) __printf(2, 3);

void __iwl_info(struct device *dev, const char *fmt, ...) __printf(2, 3);

void __iwl_crit(struct device *dev, const char *fmt, ...) __printf(2, 3);



/* No matter what is m (priv, bus, trans), this will work */

#define IWL_ERR(m, f, a...) __iwl_err((m)->dev, false, false, f, ## a)
@@ -52,9 +52,9 @@ void __iwl_crit(struct device *dev, const char *fmt, ...); 
#if defined(CONFIG_IWLWIFI_DEBUG) || defined(CONFIG_IWLWIFI_DEVICE_TRACING)

void __iwl_dbg(struct device *dev,

	       u32 level, bool limit, const char *function,

	       const char *fmt, ...);

	       const char *fmt, ...) __printf(5, 6);

#else

static inline void

__printf(5, 6) static inline void

__iwl_dbg(struct device *dev,

	  u32 level, bool limit, const char *function,

	  const char *fmt, ...)