Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13f9bba7 authored by Saeed Mahameed's avatar Saeed Mahameed Committed by David S. Miller
Browse files

net/mlx5e: Set port MTU on netdev creation rather on open 



Port mtu shouldn't be written to hardware on every single interface
open.
Here we set it only when needed, on change_mtu and netdevice creation.

Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 98a384ec

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+3 −4
Original line number Diff line number Diff line
@@ -1826,10 +1826,6 @@ int mlx5e_open_locked(struct net_device *netdev) 
	netif_set_real_num_tx_queues(netdev, num_txqs);

	netif_set_real_num_rx_queues(netdev, priv->params.num_channels);



	err = mlx5e_set_dev_port_mtu(netdev);

	if (err)

		goto err_clear_state_opened_flag;



	err = mlx5e_open_channels(priv);

	if (err) {

		netdev_err(netdev, "%s: mlx5e_open_channels failed, %d\n",
@@ -2593,6 +2589,7 @@ static int mlx5e_change_mtu(struct net_device *netdev, int new_mtu) 
		mlx5e_close_locked(netdev);



	netdev->mtu = new_mtu;

	mlx5e_set_dev_port_mtu(netdev);



	if (was_opened)

		err = mlx5e_open_locked(netdev);
@@ -3463,6 +3460,8 @@ void *mlx5e_create_netdev(struct mlx5_core_dev *mdev, 


	mlx5e_init_l2_addr(priv);



	mlx5e_set_dev_port_mtu(netdev);



	err = register_netdev(netdev);

	if (err) {

		mlx5_core_err(mdev, "register_netdev failed, %d\n", err);