Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12cdd3d7 authored by Nicolas Kaiser's avatar Nicolas Kaiser Committed by Kevin Hilman
Browse files

davinci: aemif: signedness bug in davinci_aemif_setup_timing() 



aemif_calc_rate() can return a negative error value, so all the
variables that get tested for this value need to be signed.

The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
(0xf << 26). Using a signed instead of an unsigned integer
shouldn't make a difference here.

Signed-off-by: default avatarNicolas Kaiser <nikai@nikai.net>
Acked-by: default avatarSekhar Nori <nsekhar@ti.com>
Signed-off-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
parent 1a07bfb5

arch/arm/mach-davinci/aemif.c

+1 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ int davinci_aemif_setup_timing(struct davinci_aemif_timing *t, 
					void __iomem *base, unsigned cs)

{

	unsigned set, val;

	unsigned ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup;

	int ta, rhold, rstrobe, rsetup, whold, wstrobe, wsetup;

	unsigned offset = A1CR_OFFSET + cs * 4;

	struct clk *aemif_clk;

	unsigned long clkrate;