Commit 1227633a authored Dec 31, 2010 by Mike Christie Committed by James Bottomley Dec 31, 2010

[SCSI] be2iscsi: fix null ptr when accessing task hdr



If alloc_pdu fails then the task->hdr pointer may not be
set. This adds a check for this case in the cleanup callback.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent bc7accec

drivers/scsi/be2iscsi/be_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3914,7 +3914,8 @@ static void beiscsi_cleanup_task(struct iscsi_task *task)
		io_task->psgl_handle = NULL;
		}
		} else {
		if ((task->hdr->opcode & ISCSI_OPCODE_MASK) == ISCSI_OP_LOGIN)
		if (task->hdr &&
		((task->hdr->opcode & ISCSI_OPCODE_MASK) == ISCSI_OP_LOGIN))
		return;
		if (io_task->psgl_handle) {
		spin_lock(&phba->mgmt_sgl_lock);