Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12197bf2 authored by Romain Izard's avatar Romain Izard Committed by Brian Norris
Browse files

mtd: atmel_nand: Do not warn on bitflips 



When using multi-bit ECC, it is normal for the NAND Flash driver to
correct bit errors during the life of the product. Those errors will
only be cleared once a threshold has been reached, and corrections can
occur regularly before this.

Use only dev_dbg and not dev_info to report the bitflips, to keep the
system log clean when everything works correctly.

Signed-off-by: default avatarRomain Izard <romain.izard.pro@gmail.com>
Acked-by: default avatarWenyou Yang <wenyou.yang@atmel.com>
Reviewed-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent 4be4e03e

drivers/mtd/nand/atmel_nand.c

+2 −2
Original line number Diff line number Diff line
@@ -825,7 +825,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, 
			*(buf + byte_pos) ^= (1 << bit_pos);



			pos = sector_num * host->pmecc_sector_size + byte_pos;

			dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",

			dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",

				pos, bit_pos, err_byte, *(buf + byte_pos));

		} else {

			/* Bit flip in OOB area */
@@ -835,7 +835,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, 
			ecc[tmp] ^= (1 << bit_pos);



			pos = tmp + nand_chip->ecc.layout->eccpos[0];

			dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",

			dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n",

				pos, bit_pos, err_byte, ecc[tmp]);

		}