Commit 11b642b8 authored Nov 21, 2016 by Bart Van Assche Committed by Doug Ledford Dec 14, 2016

IPoIB: Avoid reading an uninitialized member variable



This patch avoids that Coverity reports the following:

    Using uninitialized value port_attr.state when calling printk

Fixes: commit 94232d9c ("IPoIB: Start multicast join process only on active ports")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 2fe2f378

drivers/infiniband/ulp/ipoib/ipoib_multicast.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -575,8 +575,11 @@ void ipoib_mcast_join_task(struct work_struct *work)
		if (!test_bit(IPOIB_FLAG_OPER_UP, &priv->flags))
		return;

		if (ib_query_port(priv->ca, priv->port, &port_attr) \|\|
		port_attr.state != IB_PORT_ACTIVE) {
		if (ib_query_port(priv->ca, priv->port, &port_attr)) {
		ipoib_dbg(priv, "ib_query_port() failed\n");
		return;
		}
		if (port_attr.state != IB_PORT_ACTIVE) {
		ipoib_dbg(priv, "port state is not ACTIVE (state = %d) suspending join task\n",
		port_attr.state);
		return;