Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 114e9fc9 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: Remove outdated comment about lock_super() 



ext4_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked.  The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 8df9675f

fs/ext4/super.c

+0 −8
Original line number Diff line number Diff line
@@ -2828,14 +2828,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) 
		goto failed_mount4;

	};



	/*

	 * akpm: core read_super() calls in here with the superblock locked.

	 * That deadlocks, because orphan cleanup needs to lock the superblock

	 * in numerous places.  Here we just pop the lock - it's relatively

	 * harmless, because we are now ready to accept write_super() requests,

	 * and aviro says that's the only reason for hanging onto the

	 * superblock lock.

	 */

	EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS;

	ext4_orphan_cleanup(sb, es);

	EXT4_SB(sb)->s_mount_state &= ~EXT4_ORPHAN_FS;