Commit 10c998ef authored May 19, 2017 by Wolfram Sang Committed by Ulf Hansson Jun 20, 2017

mmc: tmio: make tmio_mmc_request function more readable

This part confused me and I had to read it twice until I got it. Let's
follow the standard pattern to bail out if something is wrong and keep
in the body of the function when everything is as expected.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent e1df7ae3

drivers/mmc/host/tmio_mmc_core.c

+6 −5

Original line number	Diff line number	Diff line
		@@ -926,11 +926,12 @@ static void tmio_mmc_request(struct mmc_host mmc, struct mmc_request mrq)
		}

		ret = tmio_mmc_start_command(host, mrq->cmd);
		if (!ret) {
		if (ret)
		goto fail;

		schedule_delayed_work(&host->delayed_reset_work,
		msecs_to_jiffies(CMDREQ_TIMEOUT));
		return;
		}

		fail:
		host->force_pio = false;