Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10b614ea authored by Jiri Slaby's avatar Jiri Slaby Committed by Ingo Molnar
Browse files

x86_32: summit_32, use BAD_APICID 



Use BAD_APICID instead of 0xFF constants in summit_cpu_mask_to_apicid.

Also remove bogus comments about what we actually return.

Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent ecda0628

arch/x86/kernel/apic/summit_32.c

+4 −6
Original line number Diff line number Diff line
@@ -303,12 +303,10 @@ static inline unsigned int summit_cpu_mask_to_apicid(const cpumask_t *cpumask) 
	int cpu;



	num_bits_set = cpus_weight(*cpumask);

	/* Return id to all */

	if (num_bits_set >= nr_cpu_ids)

		return 0xFF;

		return BAD_APICID;

	/*

	 * The cpus in the mask must all be on the apic cluster.  If are not

	 * on the same apicid cluster return default value of target_cpus():

	 * The cpus in the mask must all be on the apic cluster.

	 */

	cpu = first_cpu(*cpumask);

	apicid = summit_cpu_to_logical_apicid(cpu);
@@ -320,7 +318,7 @@ static inline unsigned int summit_cpu_mask_to_apicid(const cpumask_t *cpumask) 
			if (APIC_CLUSTER(apicid) != APIC_CLUSTER(new_apicid)) {

				printk("%s: Not a valid mask!\n", __func__);



				return 0xFF;

				return BAD_APICID;

			}

			apicid = apicid | new_apicid;

			cpus_found++;