Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 102ecddc authored by Jack Pham's avatar Jack Pham
Browse files

usb: pd: qpnp-pdphy: Remove trimming



The TX_TRIM_3 register should not need to be written by the
kernel driver, as we should rely on the part to already have
the correct value either hard coded or adjusted by the boot
loader. Being that it is a secure register also implies as much.

Change-Id: I65cd24b26daa53b2169326376771396e882e4c69
Signed-off-by: default avatarJack Pham <jackp@codeaurora.org>
parent d238bab0
Loading
Loading
Loading
Loading
+0 −11
Original line number Diff line number Diff line
@@ -72,9 +72,6 @@

#define USB_PDPHY_RX_BUFFER		0x80

#define USB_PDPHY_SEC_ACCESS		0xD0
#define USB_PDPHY_TRIM_3		0xF3

/* VDD regulator */
#define VDD_PDPHY_VOL_MIN		2800000 /* uV */
#define VDD_PDPHY_VOL_MAX		3300000 /* uV */
@@ -841,14 +838,6 @@ static int pdphy_probe(struct platform_device *pdev)
	if (ret < 0)
		return ret;

	ret = pdphy_reg_write(pdphy, USB_PDPHY_SEC_ACCESS, 0xA5);
	if (ret)
		return ret;

	ret = pdphy_reg_write(pdphy, USB_PDPHY_TRIM_3, 0x2);
	if (ret)
		return ret;

	/* usbpd_create() could call back to us, so have __pdphy ready */
	__pdphy = pdphy;