Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1020dfd1 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Linus Walleij
Browse files

gpio: of: move chip->of_gpio_n_cells checking to of_gpiochip_add() 



Do this sanity check only once when the gpio_chip is added
rather than every time gpio-hog is handled.

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent be715343

drivers/gpio/gpiolib-of.c

+4 −1
Original line number Diff line number Diff line
@@ -155,7 +155,7 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, 
	if (ret)

		return ERR_PTR(ret);



	if (tmp > MAX_PHANDLE_ARGS || tmp != chip->of_gpio_n_cells)

	if (tmp != chip->of_gpio_n_cells)

		return ERR_PTR(-EINVAL);



	gpiospec.np = chip_np;
@@ -486,6 +486,9 @@ int of_gpiochip_add(struct gpio_chip *chip) 
		chip->of_xlate = of_gpio_simple_xlate;

	}



	if (chip->of_gpio_n_cells > MAX_PHANDLE_ARGS)

		return -EINVAL;



	status = of_gpiochip_add_pin_range(chip);

	if (status)

		return status;