Commit 0f4ca55e authored Jun 26, 2018 by Brandon Maier Committed by Greg Kroah-Hartman Oct 03, 2018

net: phy: xgmiitorgmii: Check read_status results



[ Upstream commit 8d0752d11312be830c33e84dfd1016e6a47c2938 ]

We're ignoring the result of the attached phy device's read_status().
Return it so we can detect errors.

Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8d9fd12b

drivers/net/phy/xilinx_gmii2rgmii.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -40,8 +40,11 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
		{
		struct gmii2rgmii *priv = phydev->priv;
		u16 val = 0;
		int err;

		priv->phy_drv->read_status(phydev);
		err = priv->phy_drv->read_status(phydev);
		if (err < 0)
		return err;

		val = mdiobus_read(phydev->mdio.bus, priv->addr, XILINX_GMII2RGMII_REG);
		val &= ~XILINX_GMII2RGMII_SPEED_MASK;