Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d3f5cce authored by Kalesh AP's avatar Kalesh AP Committed by David S. Miller
Browse files

be2net: define BE_MAX_MTU 



This patch defines a new macro BE_MAX_MTU to make the code in be_change_mtu()
more readable.

Signed-off-by: default avatarKalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: default avatarSathya Perla <sathya.perla@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3fb8cb80

drivers/net/ethernet/emulex/benet/be.h

+2 −0
Original line number Diff line number Diff line
@@ -86,6 +86,8 @@ static inline char *nic_name(struct pci_dev *pdev) 


#define BE_MAX_JUMBO_FRAME_SIZE	9018

#define BE_MIN_MTU		256

#define BE_MAX_MTU              (BE_MAX_JUMBO_FRAME_SIZE -	\

				 (ETH_HLEN + ETH_FCS_LEN))



#define BE_NUM_VLANS_SUPPORTED	64

#define BE_MAX_EQD		128u

drivers/net/ethernet/emulex/benet/be_main.c

+7 −7
Original line number Diff line number Diff line
@@ -1073,15 +1073,15 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, struct net_device *netdev) 
static int be_change_mtu(struct net_device *netdev, int new_mtu)

{

	struct be_adapter *adapter = netdev_priv(netdev);

	if (new_mtu < BE_MIN_MTU ||

	    new_mtu > (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN))) {

		dev_info(&adapter->pdev->dev,

			 "MTU must be between %d and %d bytes\n",

			 BE_MIN_MTU,

			 (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN)));

	struct device *dev = &adapter->pdev->dev;



	if (new_mtu < BE_MIN_MTU || new_mtu > BE_MAX_MTU) {

		dev_info(dev, "MTU must be between %d and %d bytes\n",

			 BE_MIN_MTU, BE_MAX_MTU);

		return -EINVAL;

	}

	dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",



	dev_info(dev, "MTU changed from %d to %d bytes\n",

		 netdev->mtu, new_mtu);

	netdev->mtu = new_mtu;

	return 0;