Commit 0cbb0a78 authored Jul 27, 2009 by Deepak Saxena Committed by David S. Miller Jul 27, 2009

net: irda: init spinlock after memcpy



irttp_dup() copies a tsap_cb struct, but does not initialize the
spinlock in the new structure, which confuses lockdep.

Signed-off-by: Deepak Saxena <dsaxena@mvista.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8bae1b2b

net/irda/irttp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1453,6 +1453,7 @@ struct tsap_cb irttp_dup(struct tsap_cb orig, void *instance)
		}
		/* Dup */
		memcpy(new, orig, sizeof(struct tsap_cb));
		spin_lock_init(&new->lock);

		/* We don't need the old instance any more */
		spin_unlock_irqrestore(&irttp->tsaps->hb_spinlock, flags);