Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c4439c4 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

EDAC: Fix memleak in module init error path 



[ Upstream commit 4708aa85d50cc6e962dfa8acf5ad4e0d290a21db ]

Make sure to use put_device() to free the initialised struct device so
that resources managed by driver core also gets released in the event of
a registration failure.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Cc: Denis Kirjanov <kirjanov@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>
Fixes: 2d56b109 ("EDAC: Handle error path in edac_mc_sysfs_init() properly")
Link: http://lkml.kernel.org/r/20180612124335.6420-1-johan@kernel.org


Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4f7bea8

drivers/edac/edac_mc_sysfs.c

+3 −3
Original line number Diff line number Diff line
@@ -1097,14 +1097,14 @@ int __init edac_mc_sysfs_init(void) 


	err = device_add(mci_pdev);

	if (err < 0)

		goto out_dev_free;

		goto out_put_device;



	edac_dbg(0, "device %s created\n", dev_name(mci_pdev));



	return 0;



 out_dev_free:

	kfree(mci_pdev);

 out_put_device:

	put_device(mci_pdev);

 out:

	return err;

}