Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c329e40 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Ritesh Harjani
Browse files

sysfs: convert BUG_ON to WARN_ON 



It's rude to crash the system just because the developer did something
wrong, as it prevents them from usually even seeing what went wrong.

So convert the few BUG_ON() calls that have snuck into the sysfs code
over the years to WARN_ON() to make it more "friendly".  All of these
are able to be recovered from, so it makes no sense to crash.

Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Git-Repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git


Git-Commit: de96e9fea7ba56042f105b6fe163447b280eb800
Change-Id: I0008965755b1c83edc097e0f4a1a86e534569bb2
Signed-off-by: default avatarRitesh Harjani <riteshh@codeaurora.org>
parent c0f77713

fs/sysfs/dir.c

+2 −1
Original line number Diff line number Diff line
@@ -42,7 +42,8 @@ int sysfs_create_dir_ns(struct kobject *kobj, const void *ns) 
{

	struct kernfs_node *parent, *kn;



	BUG_ON(!kobj);

	if (WARN_ON(!kobj))

		return -EINVAL;



	if (kobj->parent)

		parent = kobj->parent->sd;

fs/sysfs/file.c

+4 −2
Original line number Diff line number Diff line
@@ -329,7 +329,8 @@ int sysfs_add_file(struct kernfs_node *parent, const struct attribute *attr, 
int sysfs_create_file_ns(struct kobject *kobj, const struct attribute *attr,

			 const void *ns)

{

	BUG_ON(!kobj || !kobj->sd || !attr);

	if (WARN_ON(!kobj || !kobj->sd || !attr))

		return -EINVAL;



	return sysfs_add_file_mode_ns(kobj->sd, attr, false, attr->mode, ns);
@@ -532,7 +533,8 @@ EXPORT_SYMBOL_GPL(sysfs_remove_file_from_group); 
int sysfs_create_bin_file(struct kobject *kobj,

			  const struct bin_attribute *attr)

{

	BUG_ON(!kobj || !kobj->sd || !attr);

	if (WARN_ON(!kobj || !kobj->sd || !attr))

		return -EINVAL;



	return sysfs_add_file(kobj->sd, &attr->attr, true);

}

fs/sysfs/group.c

+2 −1
Original line number Diff line number Diff line
@@ -110,7 +110,8 @@ static int internal_create_group(struct kobject *kobj, int update, 
	struct kernfs_node *kn;

	int error;



	BUG_ON(!kobj || (!update && !kobj->sd));

	if (WARN_ON(!kobj || (!update && !kobj->sd)))

		return -EINVAL;



	/* Updates may happen before the object has been instantiated */

	if (unlikely(update && !kobj->sd))

fs/sysfs/symlink.c

+2 −1
Original line number Diff line number Diff line
@@ -24,7 +24,8 @@ static int sysfs_do_create_link_sd(struct kernfs_node *parent, 
{

	struct kernfs_node *kn, *target = NULL;



	BUG_ON(!name || !parent);

	if (WARN_ON(!name || !parent))

		return -EINVAL;



	/*

	 * We don't own @target_kobj and it may be removed at any time.