Commit 0bd454c0 authored Jun 21, 2017 by Tahsin Erdogan Committed by Theodore Ts'o Jun 21, 2017

ext4: ext4_xattr_value_same() should return false for external data



ext4_xattr_value_same() is used as a quick optimization in case the new
xattr value is identical to the previous value. When xattr value is
stored in a xattr inode the check becomes expensive so it is better to
just assume that they are not equal.

Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 990461dd

fs/ext4/xattr.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1426,6 +1426,9 @@ static int ext4_xattr_value_same(struct ext4_xattr_search *s,
		{
		void *value;

		/* When e_value_inum is set the value is stored externally. */
		if (s->here->e_value_inum)
		return 0;
		if (le32_to_cpu(s->here->e_value_size) != i->value_len)
		return 0;
		value = ((void *)s->base) + le16_to_cpu(s->here->e_value_offs);