Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a67fe45 authored by Malcolm Priestley's avatar Malcolm Priestley Committed by Mauro Carvalho Chehab
Browse files

[media] lmedm04: fix data usage past the end of the buffer 



On Mon, 2012-08-13 at 19:58 +0300, Dan Carpenter wrote:
> Hello Mauro Carvalho Chehab,
>
> The patch db6651a9: "[media] lmedm04: fix build" from Aug 12,
> 2012, leads to the following warning:
> drivers/media/dvb/dvb-usb-v2/lmedm04.c:769 lme2510_download_firmware()
> 	 error: usb_control_msg() 'data' too small (128 vs 265)
>
>    737          data = kzalloc(128, GFP_KERNEL);
>                                ^^^
> data is 128 bytes.

Control isn't used, so remove it.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ae530205

drivers/media/dvb/dvb-usb-v2/lmedm04.c

+0 −4
Original line number Diff line number Diff line
@@ -766,10 +766,6 @@ static int lme2510_download_firmware(struct dvb_usb_device *d, 
		}

	}



	usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0),

			0x06, 0x80, 0x0200, 0x00, data, 0x0109, 1000);





	data[0] = 0x8a;

	len_in = 1;

	msleep(2000);