Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a5c6a22 authored by Frans Klaver's avatar Frans Klaver Committed by Sebastian Reichel
Browse files

power: reset: ltc2952: prefer devm_kzalloc over kzalloc 



Make use of the fact that the allocated resources can be automatically
deallocated. This reduces cleanup code and chance of leaks.

Signed-off-by: default avatarFrans Klaver <frans.klaver@xsens.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 0160817d

drivers/power/reset/ltc2952-poweroff.c

+3 −8
Original line number Diff line number Diff line
@@ -292,7 +292,8 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev) 
		return -EBUSY;

	}



	ltc2952_data = kzalloc(sizeof(*ltc2952_data), GFP_KERNEL);

	ltc2952_data = devm_kzalloc(&pdev->dev, sizeof(*ltc2952_data),

				    GFP_KERNEL);

	if (!ltc2952_data)

		return -ENOMEM;
@@ -300,17 +301,13 @@ static int ltc2952_poweroff_probe(struct platform_device *pdev) 


	ret = ltc2952_poweroff_init(pdev);

	if (ret)

		goto err;

		return ret;



	pm_power_off = &ltc2952_poweroff_kill;



	dev_info(&pdev->dev, "probe successful\n");



	return 0;



err:

	kfree(ltc2952_data);

	return ret;

}



static int ltc2952_poweroff_remove(struct platform_device *pdev)
@@ -324,8 +321,6 @@ static int ltc2952_poweroff_remove(struct platform_device *pdev) 


		for (i = 0; i < ARRAY_SIZE(ltc2952_data->gpio); i++)

			gpiod_put(ltc2952_data->gpio[i]);



		kfree(ltc2952_data);

	}



	return 0;