Commit 09e258af authored Oct 29, 2016 by Wei Yongjun Committed by Linus Walleij Oct 31, 2016

gpio: of: add missing of_node_put() in of_gpiochip_scan_gpios()



When terminating for_each_available_child_of_node() iteration
with break or return, of_node_put() should be used to prevent
stale device node references from being left behind.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 550a9532

drivers/gpio/gpiolib-of.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -247,9 +247,11 @@ static int of_gpiochip_scan_gpios(struct gpio_chip *chip)
		continue;

		ret = gpiod_hog(desc, name, lflags, dflags);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		return ret;
		}
		}

		return 0;
		}