Commit 09e0834f authored Oct 20, 2011 by Akira Fujita Committed by Theodore Ts'o Oct 20, 2011

ext4: fix deadlock in ext4_ordered_write_end()



If ext4_jbd2_file_inode() in ext4_ordered_write_end() fails for some
reasons, this function returns to caller without unlocking the page.
It leads to the deadlock, and the patch fixes this issue.

Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent ee90d57e

fs/ext4/inode.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -959,7 +959,11 @@ static int ext4_ordered_write_end(struct file *file,
		ext4_orphan_add(handle, inode);
		if (ret2 < 0)
		ret = ret2;
		} else {
		unlock_page(page);
		page_cache_release(page);
		}

		ret2 = ext4_journal_stop(handle);
		if (!ret)
		ret = ret2;