Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0946b8c5 authored by Dave Martin's avatar Dave Martin Committed by Russell King
Browse files

ARM: 6517/1: kexec: Add missing memory clobber to inline asm in crash_setup_regs() 



Currently, the inline asm is passed &newregs->ARM_r0 as in input,
when modifying multiple fields of newregs.

It's plausible to assume that GCC will assume newregs->ARM_r0 is
modified when passed the address, but unfortunately this assumption
is incorrect.

Also, GCC has no way to guess that the other ARM_r* fields are
modified without the addition of a "memory" clobber.

Signed-off-by: default avatarDave Martin <dave.martin@linaro.org>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent cb5d39b3

arch/arm/include/asm/kexec.h

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ static inline void crash_setup_regs(struct pt_regs *newregs, 
		memcpy(newregs, oldregs, sizeof(*newregs));

	} else {

		__asm__ __volatile__ ("stmia %0, {r0 - r15}"

				      : : "r" (&newregs->ARM_r0));

				      : : "r" (&newregs->ARM_r0) : "memory");

		__asm__ __volatile__ ("mrs %0, cpsr"

				      : "=r" (newregs->ARM_cpsr));

	}