Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09424c50 authored by Roger Quadros's avatar Roger Quadros Committed by Felipe Balbi
Browse files

usb: gadget: f_uvc: Fix SuperSpeed companion descriptor's wBytesPerInterval 



The streaming_maxburst module parameter is 0 offset (0..15)
so we must add 1 while using it for wBytesPerInterval
calculation for the SuperSpeed companion descriptor.

Without this host uvcvideo driver will always see the wrong
wBytesPerInterval for SuperSpeed uvc gadget and may not find
a suitable video interface endpoint.
e.g. for streaming_maxburst = 0 case it will always
fail as wBytePerInterval was evaluating to 0.

Cc: stable@vger.kernel.org
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarRoger Quadros <rogerq@ti.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 74098c4a

drivers/usb/gadget/function/f_uvc.c

+1 −1
Original line number Diff line number Diff line
@@ -625,7 +625,7 @@ uvc_function_bind(struct usb_configuration *c, struct usb_function *f) 
	uvc_ss_streaming_comp.bMaxBurst = opts->streaming_maxburst;

	uvc_ss_streaming_comp.wBytesPerInterval =

		cpu_to_le16(max_packet_size * max_packet_mult *

			    opts->streaming_maxburst);

			    (opts->streaming_maxburst + 1));



	/* Allocate endpoints. */

	ep = usb_ep_autoconfig(cdev->gadget, &uvc_control_ep);