Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08512557 authored by Al Viro's avatar Al Viro Committed by Greg Kroah-Hartman
Browse files

rpc_pipefs: fix double-dput() 



commit 4a3877c4cedd95543f8726b0a98743ed8db0c0fb upstream.

if we ever hit rpc_gssd_dummy_depopulate() dentry passed to
it has refcount equal to 1.  __rpc_rmpipe() drops it and
dput() done after that hits an already freed dentry.

Cc: stable@kernel.org
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0bb4a6f2

net/sunrpc/rpc_pipe.c

+1 −0
Original line number Diff line number Diff line
@@ -1375,6 +1375,7 @@ rpc_gssd_dummy_depopulate(struct dentry *pipe_dentry) 
	struct dentry *clnt_dir = pipe_dentry->d_parent;

	struct dentry *gssd_dir = clnt_dir->d_parent;



	dget(pipe_dentry);

	__rpc_rmpipe(d_inode(clnt_dir), pipe_dentry);

	__rpc_depopulate(clnt_dir, gssd_dummy_info_file, 0, 1);

	__rpc_depopulate(gssd_dir, gssd_dummy_clnt_dir, 0, 1);