Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0825f191 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: my_device_changestate: add error response 



The function my_device_changestate was not sending a response if there
was an error with the CONTROLVM message.

Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a80e98a

drivers/staging/unisys/visorbus/visorchipset.c

+12 −5
Original line number Diff line number Diff line
@@ -1046,15 +1046,22 @@ my_device_changestate(struct controlvm_message *inmsg) 
		POSTCODE_LINUX_4(DEVICE_CHANGESTATE_FAILURE_PC, dev_no, bus_no,

				 POSTCODE_SEVERITY_ERR);

		rc = -CONTROLVM_RESP_ERROR_DEVICE_INVALID;

	} else if (dev_info->state.created == 0) {

		goto err_respond;

	}

	if (dev_info->state.created == 0) {

		POSTCODE_LINUX_4(DEVICE_CHANGESTATE_FAILURE_PC, dev_no, bus_no,

				 POSTCODE_SEVERITY_ERR);

		rc = -CONTROLVM_RESP_ERROR_DEVICE_INVALID;

		goto err_respond;

	}

	if ((rc >= CONTROLVM_RESP_SUCCESS) && dev_info)



	device_epilog(dev_info, state,

		      CONTROLVM_DEVICE_CHANGESTATE, &inmsg->hdr, rc,

		      inmsg->hdr.flags.response_expected == 1, 1);

	return;



err_respond:

	device_responder(inmsg->hdr.id, &inmsg->hdr, rc);

}



static void