Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07239fc8 authored by long.wanglong's avatar long.wanglong Committed by Tony Luck
Browse files

fs/pstore: Optimization function ramoops_init_przs 



The value of cxt->record_size does not change in the loop,
so this patch optimize the assign statement by dropping
sz entirely and using cxt->record_size in its place.

Signed-off-by: default avatarWang Long <long.wanglong@huawei.com>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent 42222c2a

fs/pstore/ram.c

+3 −5
Original line number Diff line number Diff line
@@ -394,18 +394,16 @@ static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt, 
	}



	for (i = 0; i < cxt->max_dump_cnt; i++) {

		size_t sz = cxt->record_size;



		cxt->przs[i] = persistent_ram_new(*paddr, sz, 0,

		cxt->przs[i] = persistent_ram_new(*paddr, cxt->record_size, 0,

						  &cxt->ecc_info,

						  cxt->memtype);

		if (IS_ERR(cxt->przs[i])) {

			err = PTR_ERR(cxt->przs[i]);

			dev_err(dev, "failed to request mem region (0x%zx@0x%llx): %d\n",

				sz, (unsigned long long)*paddr, err);

				cxt->record_size, (unsigned long long)*paddr, err);

			goto fail_prz;

		}

		*paddr += sz;

		*paddr += cxt->record_size;

	}



	return 0;