Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06892f2e authored by Tomer Tayar's avatar Tomer Tayar Committed by David S. Miller
Browse files

qed: Flush slowpath tasklet on stop 



Today, driver has a synchronization point while closing
the device which synchronizes its slowpath interrupt line.
However, that's insufficient as that ISR would schedule the
slowpath-tasklet - so even after ISR is over it's possible the
handling of the interrupt has not completed.

By doing a disable/enable on the taskelt we guarantee that all
HW events that should no longer be genereated from that point
onward in the flow are truly behind us.

Signed-off-by: default avatarTomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c31a314b

drivers/net/ethernet/qlogic/qed/qed_main.c

+14 −0
Original line number Diff line number Diff line
@@ -606,6 +606,18 @@ int qed_slowpath_irq_req(struct qed_hwfn *hwfn) 
	return rc;

}



static void qed_slowpath_tasklet_flush(struct qed_hwfn *p_hwfn)

{

	/* Calling the disable function will make sure that any

	 * currently-running function is completed. The following call to the

	 * enable function makes this sequence a flush-like operation.

	 */

	if (p_hwfn->b_sp_dpc_enabled) {

		tasklet_disable(p_hwfn->sp_dpc);

		tasklet_enable(p_hwfn->sp_dpc);

	}

}



void qed_slowpath_irq_sync(struct qed_hwfn *p_hwfn)

{

	struct qed_dev *cdev = p_hwfn->cdev;
@@ -617,6 +629,8 @@ void qed_slowpath_irq_sync(struct qed_hwfn *p_hwfn) 
		synchronize_irq(cdev->int_params.msix_table[id].vector);

	else

		synchronize_irq(cdev->pdev->irq);



	qed_slowpath_tasklet_flush(p_hwfn);

}



static void qed_slowpath_irq_free(struct qed_dev *cdev)