Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0656f6cf authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Liam Girdwood
Browse files

ASoC: tpa6130a2: Revisit power-up sequence 



There are no known problems with current power-up sequence which first sets
the /shutdown pin high and then enables the supply. However, swap the order
so that the device is kept in shutdown/reset mode during the supply voltage
transition since slowly rising voltages can usually cause problems if the
device is not kept in reset.

Signed-off-by: default avatarJarkko Nikula <jhnikula@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 414c73ab

sound/soc/codecs/tpa6130a2.c

+3 −3
Original line number Diff line number Diff line
@@ -126,9 +126,6 @@ static int tpa6130a2_power(int power) 


	mutex_lock(&data->mutex);

	if (power) {

		/* Power on */

		if (data->power_gpio >= 0)

			gpio_set_value(data->power_gpio, 1);



		ret = regulator_enable(data->supply);

		if (ret != 0) {
@@ -136,6 +133,9 @@ static int tpa6130a2_power(int power) 
				"Failed to enable supply: %d\n", ret);

			goto exit;

		}

		/* Power on */

		if (data->power_gpio >= 0)

			gpio_set_value(data->power_gpio, 1);



		data->power_state = 1;

		ret = tpa6130a2_initialize();