Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0643ee4f authored by Tom Herbert's avatar Tom Herbert Committed by David S. Miller
Browse files

inet: Fix get port to handle zero port number with soreuseport set 



A user may call listen with binding an explicit port with the intent
that the kernel will assign an available port to the socket. In this
case inet_csk_get_port does a port scan. For such sockets, the user may
also set soreuseport with the intent a creating more sockets for the
port that is selected. The problem is that the initial socket being
opened could inadvertently choose an existing and unreleated port
number that was already created with soreuseport.

This patch adds a boolean parameter to inet_bind_conflict that indicates
rather soreuseport is allowed for the check (in addition to
sk->sk_reuseport). In calls to inet_bind_conflict from inet_csk_get_port
the argument is set to true if an explicit port is being looked up (snum
argument is nonzero), and is false if port scan is done.

Signed-off-by: default avatarTom Herbert <tom@herbertland.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9af7e923

include/net/inet6_connection_sock.h

+2 −1
Original line number Diff line number Diff line
@@ -22,7 +22,8 @@ struct sock; 
struct sockaddr;



int inet6_csk_bind_conflict(const struct sock *sk,

			    const struct inet_bind_bucket *tb, bool relax);

			    const struct inet_bind_bucket *tb, bool relax,

			    bool soreuseport_ok);



struct dst_entry *inet6_csk_route_req(const struct sock *sk, struct flowi6 *fl6,

				      const struct request_sock *req, u8 proto);

include/net/inet_connection_sock.h

+4 −2
Original line number Diff line number Diff line
@@ -63,7 +63,8 @@ struct inet_connection_sock_af_ops { 
#endif

	void	    (*addr2sockaddr)(struct sock *sk, struct sockaddr *);

	int	    (*bind_conflict)(const struct sock *sk,

				     const struct inet_bind_bucket *tb, bool relax);

				     const struct inet_bind_bucket *tb,

				     bool relax, bool soreuseport_ok);

	void	    (*mtu_reduced)(struct sock *sk);

};
@@ -261,7 +262,8 @@ inet_csk_rto_backoff(const struct inet_connection_sock *icsk, 
struct sock *inet_csk_accept(struct sock *sk, int flags, int *err);



int inet_csk_bind_conflict(const struct sock *sk,

			   const struct inet_bind_bucket *tb, bool relax);

			   const struct inet_bind_bucket *tb, bool relax,

			   bool soreuseport_ok);

int inet_csk_get_port(struct sock *sk, unsigned short snum);



struct dst_entry *inet_csk_route_req(const struct sock *sk, struct flowi4 *fl4,

net/ipv4/inet_connection_sock.c

+9 −5
Original line number Diff line number Diff line
@@ -45,11 +45,12 @@ void inet_get_local_port_range(struct net *net, int *low, int *high) 
EXPORT_SYMBOL(inet_get_local_port_range);



int inet_csk_bind_conflict(const struct sock *sk,

			   const struct inet_bind_bucket *tb, bool relax)

			   const struct inet_bind_bucket *tb, bool relax,

			   bool reuseport_ok)

{

	struct sock *sk2;

	int reuse = sk->sk_reuse;

	int reuseport = sk->sk_reuseport;

	bool reuse = sk->sk_reuse;

	bool reuseport = !!sk->sk_reuseport && reuseport_ok;

	kuid_t uid = sock_i_uid((struct sock *)sk);



	/*
@@ -105,6 +106,7 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum) 
	struct inet_bind_bucket *tb;

	kuid_t uid = sock_i_uid(sk);

	u32 remaining, offset;

	bool reuseport_ok = !!snum;



	if (port) {

have_port:
@@ -165,7 +167,8 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum) 
					smallest_size = tb->num_owners;

					smallest_port = port;

				}

				if (!inet_csk(sk)->icsk_af_ops->bind_conflict(sk, tb, false))

				if (!inet_csk(sk)->icsk_af_ops->bind_conflict(sk, tb, false,

									      reuseport_ok))

					goto tb_found;

				goto next_port;

			}
@@ -206,7 +209,8 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum) 
		      sk->sk_reuseport && uid_eq(tb->fastuid, uid))) &&

		    smallest_size == -1)

			goto success;

		if (inet_csk(sk)->icsk_af_ops->bind_conflict(sk, tb, true)) {

		if (inet_csk(sk)->icsk_af_ops->bind_conflict(sk, tb, true,

							     reuseport_ok)) {

			if ((reuse ||

			     (tb->fastreuseport > 0 &&

			      sk->sk_reuseport &&

net/ipv6/inet6_connection_sock.c

+4 −3
Original line number Diff line number Diff line
@@ -29,11 +29,12 @@ 
#include <net/sock_reuseport.h>



int inet6_csk_bind_conflict(const struct sock *sk,

			    const struct inet_bind_bucket *tb, bool relax)

			    const struct inet_bind_bucket *tb, bool relax,

			    bool reuseport_ok)

{

	const struct sock *sk2;

	int reuse = sk->sk_reuse;

	int reuseport = sk->sk_reuseport;

	bool reuse = !!sk->sk_reuse;

	bool reuseport = !!sk->sk_reuseport && reuseport_ok;

	kuid_t uid = sock_i_uid((struct sock *)sk);



	/* We must walk the whole port owner list in this case. -DaveM */