Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 062d0f22 authored by Michael Mera's avatar Michael Mera Committed by Doug Ledford
Browse files

IB/ocrdma: fix out of bounds access to local buffer 



In write to debugfs file 'resource_stats' the local buffer 'tmp_str' is
written at index 'count-1' where 'count' is the size of the write, so
potentially 0.

This patch filters odd values for the write size/position to avoid this
type of problem.

Signed-off-by: default avatarMichael Mera <dev@michaelmera.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent b03ee4ca

drivers/infiniband/hw/ocrdma/ocrdma_stats.c

+1 −1
Original line number Diff line number Diff line
@@ -643,7 +643,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp, 
	struct ocrdma_stats *pstats = filp->private_data;

	struct ocrdma_dev *dev = pstats->dev;



	if (count > 32)

	if (*ppos != 0 || count == 0 || count > sizeof(tmp_str))

		goto err;



	if (copy_from_user(tmp_str, buffer, count))