Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 061ef8f9 authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann
Browse files

mac802154: tx: use put_unaligned_le16 for copy crc 



This patch replaces the memcpy with a put_unaligned_le16. The placement
of crc inside of PSDU can also be unaligned. With memcpy this can fail
on some architectures.

Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Reported-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 01141234

net/mac802154/tx.c

+3 −2
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include <linux/netdevice.h>

#include <linux/if_arp.h>

#include <linux/crc-ccitt.h>

#include <asm/unaligned.h>



#include <net/rtnetlink.h>

#include <net/ieee802154_netdev.h>
@@ -84,9 +85,9 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb) 
	mac802154_monitors_rx(local, skb);



	if (!(local->hw.flags & IEEE802154_HW_OMIT_CKSUM)) {

		__le16 crc = cpu_to_le16(crc_ccitt(0, skb->data, skb->len));

		u16 crc = crc_ccitt(0, skb->data, skb->len);



		memcpy(skb_put(skb, 2), &crc, 2);

		put_unaligned_le16(crc, skb_put(skb, 2));

	}



	if (skb_cow_head(skb, local->hw.extra_tx_headroom))