Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 055a9417 authored by Qianqian Xie's avatar Qianqian Xie Committed by David S. Miller
Browse files

net: hns: bug fix for return values 



The return values in the first two functions mdiobus_write()
are ignored. The patch will fix it.

Signed-off-by: default avatarQianqian Xie <xieqianqian@huawei.com>
Signed-off-by: default avatarYisen Zhuang <Yisen.Zhuang@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8d71397b

drivers/net/ethernet/hisilicon/hns/hns_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -1013,8 +1013,8 @@ int hns_phy_led_set(struct net_device *netdev, int value) 
	struct phy_device *phy_dev = priv->phy;



	retval = phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_LED);

	retval = phy_write(phy_dev, HNS_LED_FC_REG, value);

	retval = phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_COPPER);

	retval |= phy_write(phy_dev, HNS_LED_FC_REG, value);

	retval |= phy_write(phy_dev, HNS_PHY_PAGE_REG, HNS_PHY_PAGE_COPPER);

	if (retval) {

		netdev_err(netdev, "mdiobus_write fail !\n");

		return retval;