Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 042df23a authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: iuu_phoenix.c: remove dbg() tracing calls 



dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Johan Hovold <jhovold@gmail.com>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b9783555

drivers/usb/serial/iuu_phoenix.c

+0 −38
Original line number Diff line number Diff line
@@ -135,8 +135,6 @@ static void iuu_release(struct usb_serial *serial) 
	if (!port)

		return;



	dbg("%s", __func__);



	if (priv) {

		iuu_free_buf(priv);

		dbg("%s - I will free all", __func__);
@@ -198,8 +196,6 @@ static void iuu_rxcmd(struct urb *urb) 
	int result;

	int status = urb->status;



	dbg("%s - enter", __func__);



	if (status) {

		dbg("%s - status = %d", __func__, status);

		/* error stop all */
@@ -221,7 +217,6 @@ static int iuu_reset(struct usb_serial_port *port, u8 wt) 
	struct iuu_private *priv = usb_get_serial_port_data(port);

	int result;

	char *buf_ptr = port->write_urb->transfer_buffer;

	dbg("%s - enter", __func__);



	/* Prepare the reset sequence */
@@ -255,8 +250,6 @@ static void iuu_update_status_callback(struct urb *urb) 
	u8 *st;

	int status = urb->status;



	dbg("%s - enter", __func__);



	if (status) {

		dbg("%s - status = %d", __func__, status);

		/* error stop all */
@@ -299,8 +292,6 @@ static int iuu_status(struct usb_serial_port *port) 
{

	int result;



	dbg("%s - enter", __func__);



	memset(port->write_urb->transfer_buffer, IUU_GET_STATE_REGISTER, 1);

	usb_fill_bulk_urb(port->write_urb, port->serial->dev,

			  usb_sndbulkpipe(port->serial->dev,
@@ -318,8 +309,6 @@ static int bulk_immediate(struct usb_serial_port *port, u8 *buf, u8 count) 
	struct usb_serial *serial = port->serial;

	int actual = 0;



	dbg("%s - enter", __func__);



	/* send the data out the bulk port */



	status =
@@ -341,10 +330,7 @@ static int read_immediate(struct usb_serial_port *port, u8 *buf, u8 count) 
	struct usb_serial *serial = port->serial;

	int actual = 0;



	dbg("%s - enter", __func__);



	/* send the data out the bulk port */



	status =

	    usb_bulk_msg(serial->dev,

			 usb_rcvbulkpipe(serial->dev,
@@ -367,8 +353,6 @@ static int iuu_led(struct usb_serial_port *port, unsigned int R, 
	if (!buf)

		return -ENOMEM;



	dbg("%s - enter", __func__);



	buf[0] = IUU_SET_LED;

	buf[1] = R & 0xFF;

	buf[2] = (R >> 8) & 0xFF;
@@ -460,8 +444,6 @@ static int iuu_clk(struct usb_serial_port *port, int dwFrq) 
	unsigned int P2 = 0;

	int frq = (int)dwFrq;



	dbg("%s - enter", __func__);



	if (frq == 0) {

		priv->buf[Count++] = IUU_UART_WRITE_I2C;

		priv->buf[Count++] = FrqGenAdr << 1;
@@ -590,8 +572,6 @@ static int iuu_uart_flush(struct usb_serial_port *port) 
	u8 rxcmd = IUU_UART_RX;

	struct iuu_private *priv = usb_get_serial_port_data(port);



	dbg("%s - enter", __func__);



	if (iuu_led(port, 0xF000, 0, 0, 0xFF) < 0)

		return -EIO;
@@ -630,8 +610,6 @@ static void read_buf_callback(struct urb *urb) 
	struct tty_struct *tty;

	int status = urb->status;



	dbg("%s - status = %d", __func__, status);



	if (status) {

		if (status == -EPROTO) {

			/* reschedule needed */
@@ -659,7 +637,6 @@ static int iuu_bulk_write(struct usb_serial_port *port) 
	int i;

	int buf_len;

	char *buf_ptr = port->write_urb->transfer_buffer;

	dbg("%s - enter", __func__);



	spin_lock_irqsave(&priv->lock, flags);

	*buf_ptr++ = IUU_UART_ESC;
@@ -691,7 +668,6 @@ static int iuu_bulk_write(struct usb_serial_port *port) 
static int iuu_read_buf(struct usb_serial_port *port, int len)

{

	int result;

	dbg("%s - enter", __func__);



	usb_fill_bulk_urb(port->read_urb, port->serial->dev,

			  usb_rcvbulkpipe(port->serial->dev,
@@ -713,8 +689,6 @@ static void iuu_uart_read_callback(struct urb *urb) 
	unsigned char *data = urb->transfer_buffer;

	priv->poll++;



	dbg("%s - enter", __func__);



	if (status) {

		dbg("%s - status = %d", __func__, status);

		/* error stop all */
@@ -771,7 +745,6 @@ static int iuu_uart_write(struct tty_struct *tty, struct usb_serial_port *port, 
{

	struct iuu_private *priv = usb_get_serial_port_data(port);

	unsigned long flags;

	dbg("%s - enter", __func__);



	if (count > 256)

		return -ENOMEM;
@@ -792,8 +765,6 @@ static void read_rxcmd_callback(struct urb *urb) 
	int result;

	int status = urb->status;



	dbg("%s - status = %d", __func__, status);



	if (status) {

		/* error stop all */

		return;
@@ -1015,8 +986,6 @@ static void iuu_close(struct usb_serial_port *port) 
	if (!serial)

		return;



	dbg("%s - port %d", __func__, port->number);



	iuu_uart_off(port);

	if (serial->dev) {

		/* free writebuf */
@@ -1031,7 +1000,6 @@ static void iuu_close(struct usb_serial_port *port) 


static void iuu_init_termios(struct tty_struct *tty)

{

	dbg("%s - enter", __func__);

	*(tty->termios) = tty_std_termios;

	tty->termios->c_cflag = CLOCAL | CREAD | CS8 | B9600

				| TIOCM_CTS | CSTOPB | PARENB;
@@ -1188,8 +1156,6 @@ static int iuu_vcc_set(struct usb_serial_port *port, unsigned int vcc) 
	if (!buf)

		return -ENOMEM;



	dbg("%s - enter", __func__);



	buf[0] = IUU_SET_VCC;

	buf[1] = vcc & 0xFF;

	buf[2] = (vcc >> 8) & 0xFF;
@@ -1250,15 +1216,11 @@ static DEVICE_ATTR(vcc_mode, S_IRUSR | S_IWUSR, show_vcc_mode, 


static int iuu_create_sysfs_attrs(struct usb_serial_port *port)

{

	dbg("%s", __func__);



	return device_create_file(&port->dev, &dev_attr_vcc_mode);

}



static int iuu_remove_sysfs_attrs(struct usb_serial_port *port)

{

	dbg("%s", __func__);



	device_remove_file(&port->dev, &dev_attr_vcc_mode);

	return 0;

}