Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0428c40d authored by Frans Klaver's avatar Frans Klaver Committed by Sebastian Reichel
Browse files

power: reset: ltc2952: drop empty suspend/resume functions 



Documentation/SubmittingDrivers suggests these be implemented even when
they do nothing. On the other hand, the platform code calls these
functions 'legacy'. Suspend and resume operations should go into a
pm_ops structure, pointed at by the driver's pm field. This approach
would lead to a lot of boiler plate, while achieving nothing. Drop the
functions instead.

Signed-off-by: default avatarFrans Klaver <frans.klaver@xsens.com>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent 818ca4c8

drivers/power/reset/ltc2952-poweroff.c

+0 −13
Original line number Diff line number Diff line
@@ -184,17 +184,6 @@ static void ltc2952_poweroff_kill(void) 
	gpiod_set_value(ltc2952_data->gpio_kill, 1);

}



static int ltc2952_poweroff_suspend(struct platform_device *pdev,

	pm_message_t state)

{

	return -ENOSYS;

}



static int ltc2952_poweroff_resume(struct platform_device *pdev)

{

	return -ENOSYS;

}



static void ltc2952_poweroff_default(struct ltc2952_poweroff *data)

{

	data->wde_interval = ktime_set(0, 300L*1E6L);
@@ -322,8 +311,6 @@ static struct platform_driver ltc2952_poweroff_driver = { 
		.name = "ltc2952-poweroff",

		.of_match_table = of_ltc2952_poweroff_match,

	},

	.suspend = ltc2952_poweroff_suspend,

	.resume = ltc2952_poweroff_resume,

};



module_platform_driver(ltc2952_poweroff_driver);