Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 031cb428 authored by Colin Ian King's avatar Colin Ian King Committed by Will Deacon
Browse files

arm64/crypto: remove redundant update of data 



Originally found by cppcheck:

[arch/arm64/crypto/sha2-ce-glue.c:153]: (warning) Assignment of
  function parameter has no effect outside the function. Did you
  forget dereferencing it?

Updating data by blocks * SHA256_BLOCK_SIZE at the end of
sha2_finup is redundant code and can be removed.

Acked-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 52addcf9

arch/arm64/crypto/sha2-ce-glue.c

+0 −1
Original line number Diff line number Diff line
@@ -150,7 +150,6 @@ static void sha2_finup(struct shash_desc *desc, const u8 *data, 
	kernel_neon_begin_partial(28);

	sha2_ce_transform(blocks, data, sctx->state, NULL, len);

	kernel_neon_end();

	data += blocks * SHA256_BLOCK_SIZE;

}



static int sha224_finup(struct shash_desc *desc, const u8 *data,