Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 031afe49 authored by Yuchung Cheng's avatar Yuchung Cheng Committed by David S. Miller
Browse files

tcp: fix incorrect ca_state in tail loss probe 

On receiving an ACK that covers the loss probe sequence, TLP
immediately sets the congestion state to Open, even though some packets
are not recovered and retransmisssion are on the way.  The later ACks
may trigger a WARN_ON check in step D of tcp_fastretrans_alert(), e.g.,
https://bugzilla.redhat.com/show_bug.cgi?id=989251



The fix is to follow the similar procedure in recovery by calling
tcp_try_keep_open(). The sender switches to Open state if no packets
are retransmissted. Otherwise it goes to Disorder and let subsequent
ACKs move the state to Recovery or Open.

Reported-By: default avatarMichael Sterrett <michael@sterretts.net>
Tested-By: default avatarDormando <dormando@rydia.net>
Signed-off-by: default avatarYuchung Cheng <ycheng@google.com>
Acked-by: default avatarNeal Cardwell <ncardwell@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 09b69024

net/ipv4/tcp_input.c

+1 −1
Original line number Diff line number Diff line
@@ -3291,7 +3291,7 @@ static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag) 
			tcp_init_cwnd_reduction(sk, true);

			tcp_set_ca_state(sk, TCP_CA_CWR);

			tcp_end_cwnd_reduction(sk);

			tcp_set_ca_state(sk, TCP_CA_Open);

			tcp_try_keep_open(sk);

			NET_INC_STATS_BH(sock_net(sk),

					 LINUX_MIB_TCPLOSSPROBERECOVERY);

		}