Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02794222 authored by Liu Bo's avatar Liu Bo Committed by David Sterba
Browse files

Btrfs: kill BUG_ON in run_delayed_tree_ref 



In a corrupted btrfs image, we can come across this BUG_ON and
get an unreponsive system, but if we return errors instead,
its caller can handle everything gracefully by aborting the current
transaction.

Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 6bdf131f

fs/btrfs/extent-tree.c

+7 −1
Original line number Diff line number Diff line
@@ -2352,7 +2352,13 @@ static int run_delayed_tree_ref(struct btrfs_trans_handle *trans, 
		ins.type = BTRFS_EXTENT_ITEM_KEY;

	}



	BUG_ON(node->ref_mod != 1);

	if (node->ref_mod != 1) {

		btrfs_err(root->fs_info,

	"btree block(%llu) has %d references rather than 1: action %d ref_root %llu parent %llu",

			  node->bytenr, node->ref_mod, node->action, ref_root,

			  parent);

		return -EIO;

	}

	if (node->action == BTRFS_ADD_DELAYED_REF && insert_reserved) {

		BUG_ON(!extent_op || !extent_op->update_flags);

		ret = alloc_reserved_tree_block(trans, root,