Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01cb156e authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: usb-audio: Use snd_usb_ctl_msg() for Native Instruments quirk 



snd_nativeinstruments_control_get() uses a stack as a buffer for
usb_control_msg(), but it's basically not allowed.  Replace the call
with a safer helper, snd_usb_ctl_msg(), instead.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6676f308

sound/usb/mixer_quirks.c

+2 −2
Original line number Diff line number Diff line
@@ -593,10 +593,10 @@ static int snd_nativeinstruments_control_get(struct snd_kcontrol *kcontrol, 
	if (mixer->chip->shutdown)

		ret = -ENODEV;

	else

		ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), bRequest,

		ret = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), bRequest,

				  USB_TYPE_VENDOR | USB_RECIP_DEVICE | USB_DIR_IN,

				  0, wIndex,

				  &tmp, sizeof(tmp), 1000);

				  &tmp, sizeof(tmp));

	up_read(&mixer->chip->shutdown_rwsem);



	if (ret < 0) {